Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make takeMVar exception safe #182

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Make takeMVar exception safe #182

merged 2 commits into from
Oct 21, 2024

Conversation

jasagredo
Copy link
Contributor

Closes #181

@jasagredo
Copy link
Contributor Author

jasagredo commented Oct 8, 2024 •
edited
Loading

Taking advantage of the jobs not cancelling on concurrency, we can see that this run fails:
https://github.com/input-output-hk/io-sim/actions/runs/11237006413/job/31238427869
while this one succeeds:
https://github.com/input-output-hk/io-sim/actions/runs/11237072382/job/31238658959

@jasagredo jasagredo requested a review from coot October 8, 2024 13:57
@jasagredo jasagredo force-pushed the js/exception-takemvar branch from 49855e7 to 9ed29db Compare October 8, 2024 13:59
@jasagredo jasagredo requested a review from bolt12 October 8, 2024 14:22
bolt12
bolt12 reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's talk tomorrow at the networking meeting and I'll approve then

@jasagredo jasagredo force-pushed the js/exception-takemvar branch from 9ed29db to 64d32ad Compare October 21, 2024 07:17
@bolt12 bolt12 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit db0e67c Oct 21, 2024
20 checks passed
@bolt12 bolt12 deleted the js/exception-takemvar branch October 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot left review comments

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MVars implementation is prone to deadlocks
3 participants
@jasagredo @coot @bolt12